Fix unwanted rich text formatting when pasting#6353
Merged
TobiGr merged 3 commits intoTeamNewPipe:devfrom May 29, 2021
imericxu:fix-pasting-rich-text-in-search
Merged
Fix unwanted rich text formatting when pasting#6353TobiGr merged 3 commits intoTeamNewPipe:devfrom imericxu:fix-pasting-rich-text-in-search
TobiGr merged 3 commits intoTeamNewPipe:devfrom
imericxu:fix-pasting-rich-text-in-search
Conversation
Contributor
|
thank you. please add a comment in the code that it removes rich text formatting |
AudricV
added
bug
Contributor
Author
|
Since this issue seems to only occur when pasting, should I modify the solution to an override of the paste method so there are no unnecessary checks in the TextWatcher? Edit: Nvm, looks like you’d need to override a private member or do a lot of extra stuff to achieve that unless I missed something. |
Contributor
|
thank you. Is there are reason for placing the code in |
Contributor
Author
TobiGr
approved these changes
May 29, 2021
Contributor
TobiGr
left a comment
TobiGr
left a comment
There was a problem hiding this comment.
Thanks for the explanation!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
getSpansandremoveSpanto remove text styling when pastingFixes the following issue(s)
APK testing
On the website, the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.
Due diligence